allow CloudFront logging to access KMS key #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ab77 To better understand your use case, could you help me with a quick overview of thje templates you try to bombine and the parameters you are using? Thanks, Michael |
Hello, this is just enabling CF logs to be written to encrypted buckets as per their docs. I added a new input to separate CloudFront hosting from CloudFront logging buckets as they are two different things. Do you want me to remove the input and assume to always force SSE? |
CloudFront doesn't appear to (currently) set SSE/KMS parameters on its access log write requests to S3, so a deny policy prevents logs from being written, even though encryption would happen regardless.
ab77
force-pushed
the
ab77/cloudfront-sse
branch
from
98d016b
to
fa2c078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudFront doesn't appear to (currently) set SSE/KMS parameters on its access log write requests to S3, so a deny policy prevents logs from being written, even though encryption would happen regardless.
(Override all values in parentheses)
(Run
yamllint folder/template.yaml,cfn-lint -i E1019 E3002 E2520 -t folder/template.yaml, andaws cloudformation validate-template --template-body file://folder/template.yamlbefore you open a PR)(Do not include multiple changes in one PR. Open additional PRs instead.)
allow CloudFront to use SSE-KMS to write access logs to such buckets (using bucket keys)